FIX: mutationDetection = SOURCE works also for special json types #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rPraml
commented
Aug 13, 2021
| } | ||
|
|
||
| @Override | ||
| public boolean isJsonMapper() { |
There was a problem hiding this comment.
checkme: Should we refactor that getter to isKeepSource pushSource / popSource
rbygrave
reviewed
Aug 15, 2021
| @@ -71,13 +71,25 @@ public JsonB(DocPropertyType docPropertyType, boolean nullable) { | |||
| @SuppressWarnings("rawtypes") | |||
| private abstract static class Base extends ScalarTypeJsonCollection<Set> { | |||
|
|
|||
| public Base(int dbType, DocPropertyType docPropertyType, boolean nullable) { | |||
| private boolean keepSource; | |||
| return null; | ||
| } | ||
| try { | ||
| try (InputStreamReader inputStreamReader = new InputStreamReader(is)) { | ||
| return parse(inputStreamReader); | ||
| if (isJsonMapper()) { |
| @@ -26,88 +27,95 @@ | |||
| @SuppressWarnings("rawtypes") | |||
| public abstract class ScalarTypeJsonMap extends ScalarTypeBase<Map> { | |||
|
|
|||
| private static final ScalarTypeJsonMap CLOB = new ScalarTypeJsonMap.Clob(); | |||
| } | ||
|
|
||
| @Override | ||
| public boolean isJsonMapper() { |
| } else { | ||
| return createJsonObjectMapperType(prop, dbType, DocPropertyType.OBJECT); | ||
| } | ||
| } | ||
| if (objectMapperPresent) { | ||
| if (objectMapperPresent && prop.getMutationDetection() == MutationDetection.DEFAULT) { |
There was a problem hiding this comment.
Should we just remove this altogether ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Rob, I discovered a bug in the new mutationDetection.
While
works well, it does not work for
because here Ebean uses
ScalarTypeJsonListI tried to write a test for all
@DbJsonannotations. The same problem would occur with@DbArray(which we did not use)We currently use a lot of
@DbJsonannotations and we rely on a proper dirtyValue (oldValue<->newValue) recognition.cheers
Roland