Bug: save with cascade of @OneToOne + @Version model sets version to 1 #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 1570e18)
AlexWagner
commented
Feb 11, 2022
| @@ -360,7 +360,7 @@ public void setForceUpdate(boolean forceUpdate) { | |||
| * Return true if the entity should be updated. | |||
| */ | |||
| public boolean isUpdate() { | |||
| return forceUpdate || state == STATE_LOADED; | |||
| return forceUpdate || state == STATE_LOADED || state == STATE_REFERENCE; | |||
There was a problem hiding this comment.
In our oppinion this would be the fix.
Why would you want to insert a reference-bean?
There was a problem hiding this comment.
Yes, I agree with this fix. Thanks
|
Apologies for taking a while to look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving a model, that contains a @OnetoOne Model with @Version, the child models' version will be set to 1.
Then, when the child model will be saved, a OptimisticLockException occures due to the wrong version.
(see test)
Furthermore the 'child'-model also has to have a xToMany-Relation to another model, so that the flag 'saveRecurseSkippable' in BeanPropertyAssoc is set to false.