Bug: Wrong join in query with @Inheritance and @DbForeignKey #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4bcadbb)
rbygrave
added a commit
that referenced
this pull request
Mar 14, 2022
Effectively delays an extra join added via BeanPropertyAssocOne with inheritance, such that this only occurs if a SqlTreeNode child doesn't add the join.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: Wrong join in query with @ Inheritance and @DbForeignKey
Query was:
select t0.dtype, t0.id, t0.accessor_id, t0.principal_id, t2.dtype, t0.account_account_number, t0.accessor_id, t2.dtype, t0.account_account_number, t1.id, t1.name, t2.dtype, t2.account_number
from access t0
left join account t2 on t2.account_number = t0.account_account_number
left join o_customer t1 on t1.id = t0.accessor_id and t2.dtype = 'B'
left join o_customer t3 on t3.id = t0.principal_id
where t1.status = ? and t3.status = ? and t0.id in (?,?,?,?,?)
Problem is that
and t2.dtype = 'B'is put to the wrong join