Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3423 JtaTransactionManager keeps reference to already closed scope (… #3424

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

rbygrave
Copy link
Member

…and Transaction/connection ThreadLocal) when JtaTxnListener#afterCompletion is called by a different thread

Bugfix for "Long/slow transaction reaper" in Wildfire that can close/rollback a transaction in a different thread. Fix is to use active flag to inactivate the transaction and detect that case in JtaTransactionManager.getCurrentTransaction()

…and Transaction/connection ThreadLocal) when JtaTxnListener#afterCompletion is called by a different thread

Bugfix for "Long/slow transaction reaper" in Wildfire that can close/rollback a transaction in a different thread. Fix is to use active flag to inactivate the transaction and detect that case in JtaTransactionManager.getCurrentTransaction()
Copy link
Contributor

@VictorJimenezKwast VictorJimenezKwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Changes look good. Also tested it against our stack and problem scenario and this works well. Thanks!

@rbygrave rbygrave added this to the 14.3.2 milestone Jun 20, 2024
@rbygrave rbygrave added the bug label Jun 20, 2024
@rbygrave rbygrave merged commit d5401ef into master Jun 20, 2024
1 check passed
@rbygrave rbygrave deleted the feature/3423-jta-reaper branch June 20, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants