Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right align black bar in v1.1, v1.2 #132

Open
khawkins98 opened this issue Apr 9, 2018 · 2 comments
Open

Right align black bar in v1.1, v1.2 #132

khawkins98 opened this issue Apr 9, 2018 · 2 comments

Comments

@khawkins98
Copy link
Contributor

khawkins98 commented Apr 9, 2018

Now that we've identified a right-aligned navigation in the black bar as clearer (we have evidence of this, if curious I can find it), we have changed the black bar accordingly in v1.3:

image

This, however, looks awkward when going from v1.2/v1.1 pages to v1.3:
image
image

But we can easily make this consistent and better on older versions:
image
image

And the CSS:

  • v1.2: .masthead-black-bar ul { text-align: right; }
  • v1.1:
ul#global-nav  { text-align: right;  }

#local-masthead nav ul#global-nav li {
    float: none;
    display: inline-block;
}
@sebpca
Copy link
Contributor

sebpca commented May 22, 2018

Not convinced that right hand side is clearer, first from global look&feel of the page and then from usage point of view, I have the feeling that separation between EBI links-left and EMBL links-right section was much simpler (and even more logic). Aggregating them on the right might create more confusion in particular mixing up homepage button for EBI and EMBL -EBI Hinxton button).

@khawkins98
Copy link
Contributor Author

n.b. For others coming across this: There's a little bit of a conversation happening the black bar, how it ties in with the EMBL rebrand, and other things.

So this is on pause for the moment.

If you're interested in being a part of the conversation, just shout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants