Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mma] cleaned includes #1372

Merged
merged 3 commits into from
Feb 16, 2024
Merged

[mma] cleaned includes #1372

merged 3 commits into from
Feb 16, 2024

Conversation

FlorianReimold
Copy link
Member

Description

Cleaned includes of ecal_mma.

Cherry-pick to

  • master-v5 (master for eCAL 5 feature backporting)
  • 5.13 (current stable)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

#include <iterator>
#include <memory>
#include <mutex>
#include <stdio.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]

Suggested change
#include <stdio.h>
#include <cstdio>

#include <chrono>
#include <cstdint>
#include <cstdio>
#include <stdio.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]

Suggested change
#include <stdio.h>
#include <cstdio>

#include <iostream>
#include <list>
#include <stdio.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]

Suggested change
#include <stdio.h>
#include <cstdio>

@FlorianReimold FlorianReimold added the Auto Approve Request Automatic PR Approval label Feb 16, 2024
@FlorianReimold FlorianReimold marked this pull request as ready for review February 16, 2024 07:18
@FlorianReimold FlorianReimold merged commit 33a984b into master Feb 16, 2024
14 of 15 checks passed
FlorianReimold added a commit that referenced this pull request Feb 16, 2024
FlorianReimold added a commit that referenced this pull request Feb 16, 2024
FlorianReimold added a commit that referenced this pull request Feb 16, 2024
@FlorianReimold FlorianReimold deleted the hotfix/mma_include_cleaner branch March 1, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto Approve Request Automatic PR Approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants