[master] JCEEncryptor default encryption algorithm upgrade #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…adding to AES/GCM/NoPadding . Plus extended unit test. Signed-off-by: Radek Felcman <[email protected]>
…atic one. Signed-off-by: Radek Felcman <[email protected]>
…s static context Signed-off-by: Radek Felcman <[email protected]>
…d to re-encrypt password. Signed-off-by: Radek Felcman <[email protected]>
DBWS builder test fix Signed-off-by: Radek Felcman <[email protected]>
lukasj
reviewed
Nov 29, 2023
...e.persistence.core/src/main/java/org/eclipse/persistence/internal/security/JCEEncryptor.java
Outdated
Show resolved
Hide resolved
lukasj
reviewed
Nov 29, 2023
...e.persistence.core/src/main/java/org/eclipse/persistence/tools/security/JCEEncryptorCmd.java
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| SecretKey sk = JCEEncryptorCmd.Synergizer.getAESCBCMultitasker(); | ||
| IvParameterSpec iv = JCEEncryptorCmd.Synergizer.getIvSpec(); | ||
| decryptCipherAES_CBC = Cipher.getInstance(AES_CBC); | ||
| decryptCipherAES_CBC.init(Cipher.DECRYPT_MODE, sk, iv); |
Check failure
Code scanning / CodeQL
Using a static initialization vector for encryption High
| private final Cipher decryptCipherAES_CBC; | ||
|
|
||
| public JCEEncryptorCmd() throws Exception { | ||
| decryptCipherDES_ECB = Cipher.getInstance(DES_ECB); |
Check failure
Code scanning / CodeQL
Use of a broken or risky cryptographic algorithm High
| decryptCipherDES_ECB = Cipher.getInstance(DES_ECB); | ||
| decryptCipherDES_ECB.init(Cipher.DECRYPT_MODE, JCEEncryptorCmd.Synergizer.getDESMultitasker()); | ||
|
|
||
| decryptCipherAES_ECB = Cipher.getInstance(AES_ECB); |
Check failure
Code scanning / CodeQL
Use of a broken or risky cryptographic algorithm High
|
|
||
| SecretKey sk = JCEEncryptorCmd.Synergizer.getAESCBCMultitasker(); | ||
| IvParameterSpec iv = JCEEncryptorCmd.Synergizer.getIvSpec(); | ||
| decryptCipherAES_CBC = Cipher.getInstance(AES_CBC); |
Check failure
Code scanning / CodeQL
Use of a broken or risky cryptographic algorithm High
| private static class Synergizer { | ||
|
|
||
| private static SecretKey getDESMultitasker() throws Exception { | ||
| SecretKeyFactory factory = SecretKeyFactory.getInstance("DES"); |
Check failure
Code scanning / CodeQL
Use of a broken or risky cryptographic algorithm High
lukasj
reviewed
Dec 1, 2023
...e.persistence.core/src/main/java/org/eclipse/persistence/tools/security/JCEEncryptorCmd.java
Show resolved
Hide resolved
lukasj
approved these changes
Dec 1, 2023
rfelcman
added a commit
to rfelcman/eclipselink
that referenced
this pull request
Apr 30, 2024
JCEEncryptor default encryption algorithm upgrade from AES/CBC/PKCS5Padding to AES/GCM/NoPadding . Plus extended unit test. - for AES/GCM/NoPadding random initialization vector (IV) instead of static one. - shell scripts added, resource strings moved to localization bundle DBWS builder test fix Signed-off-by: Radek Felcman <[email protected]> (cherry picked from commit 149e9ce) Signed-off-by: Radek Felcman <[email protected]>
rfelcman
added a commit
that referenced
this pull request
Apr 30, 2024
JCEEncryptor default encryption algorithm upgrade from AES/CBC/PKCS5Padding to AES/GCM/NoPadding . Plus extended unit test. - for AES/GCM/NoPadding random initialization vector (IV) instead of static one. - shell scripts added, resource strings moved to localization bundle DBWS builder test fix (cherry picked from commit 149e9ce) Signed-off-by: Radek Felcman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JCEEncryptor default encryption algorithm upgrade from AES/CBC/PKCS5Padding to AES/GCM/NoPadding .
Plus extended unit test to verify backwards compatibility.