Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCD auto-ack plugin customizations #1746

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

laurentschoelens
Copy link
Contributor

@laurentschoelens laurentschoelens commented Sep 17, 2023

The goal of this PR is to provide a way to auto-acknowledge plugin customization when using episode file to avoid generating classes twice and the xsd related to the episode contains plugin customization.

This PR will fix the following (which are duplicates in my opinion) :

This will also fix :

@laurentschoelens
Copy link
Contributor Author

Would be great if backported to EE8 (and EE9 too ?)

@laurentschoelens
Copy link
Contributor Author

Well maybe #1047 is not totally linked to the 5 other issues mentionned.
The goal of this PR is to fix the 5 issues (having generated episode file and using it to avoid class generation on 2nd build, xsd inlined customizations will then be not honored and reported as errors)

@laurentschoelens laurentschoelens changed the title GH-1047 : SCD auto-ack plugin customizations SCD auto-ack plugin customizations Sep 18, 2023
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukasj lukasj merged commit f456b44 into eclipse-ee4j:master Oct 6, 2023
5 checks passed
@laurentschoelens laurentschoelens deleted the gh-1047 branch October 9, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants