Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate deprecated Jaeger client #3190

Closed
sophokles73 opened this issue Apr 4, 2022 · 6 comments
Closed

Migrate deprecated Jaeger client #3190

sophokles73 opened this issue Apr 4, 2022 · 6 comments
Assignees
Labels
Feature Request A request for adding new functionality to Hono help wanted Issues that we would welcome any help from (new) contributors with Tracing
Milestone

Comments

@sophokles73
Copy link
Contributor

The Jaeger client used in Hono has been deprecated and will be archived mid 2022 as announced on the project website. The client should be replaced with corresponding OpenTelemetry SDKs as described in the migration guide.

@sophokles73 sophokles73 added help wanted Issues that we would welcome any help from (new) contributors with Tracing Feature Request A request for adding new functionality to Hono labels Apr 4, 2022
@sophokles73 sophokles73 added this to the 2.0.0 milestone Apr 4, 2022
@calohmn calohmn self-assigned this Apr 4, 2022
@calohmn
Copy link
Contributor

calohmn commented Apr 6, 2022

Regarding the Jaeger support in Hono, I think there are 2 options.
We could use the quarkus-opentelemetry-exporter-jaeger Quarkus extension and thereby support directly sending the traces from the Hono components to the Jaeger collector. This doesn't require the OpenTelemetry Collector.
Or, we could use the quarkus-opentelemetry-exporter-otlp Quarkus extension and require usage of the OpenTelemetry Collector. The OpenTelemetry Collector can then be configured to export to the Jaeger Collector.

I guess the 2nd option, setting up the Hono containers each with an OpenTelemetry Collector sidecar (i.e. using the agent deployment method), would be the preferred deployment setup.
So, I would rather remove the explicit jaeger build option (maven profile) and focus just on the open telemetry support.
@sophokles73 WDYT?

@sophokles73
Copy link
Contributor Author

guess the 2nd option, setting up the Hono containers each with an OpenTelemetry Collector sidecar (i.e. using the agent deployment method), would be the preferred deployment setup.

This seems to be analogous to how we deploy the Hono components in the Helm chart, right? However, for running the Hono integration tests, this sounds like we would need to start an additional container for the OpenTelemetry Collector, right?

@calohmn
Copy link
Contributor

calohmn commented Apr 6, 2022

However, for running the Hono integration tests, this sounds like we would need to start an additional container for the OpenTelemetry Collector, right?

Yes, but I think this is manageable. The quarkus-opentelemetry-exporter-jaeger extension is anyway being phased out of the main Quarkus repo at some point (see quarkusio/quarkus#17771).

@sophokles73
Copy link
Contributor Author

Ok, then let's go for the quarkus-opentelemetry-exporter-otlp ...

calohmn added a commit to bosch-io/hono that referenced this issue Apr 12, 2022
calohmn added a commit to bosch-io/hono that referenced this issue Apr 20, 2022
calohmn added a commit to bosch-io/hono that referenced this issue Apr 20, 2022
calohmn added a commit that referenced this issue Apr 20, 2022
@sophokles73
Copy link
Contributor Author

@calohmn can this be closed?

@calohmn
Copy link
Contributor

calohmn commented Apr 21, 2022

Yes, closing this - implemented via ad0f629.
#3212 and #3213 are follow-up issues.

@calohmn calohmn closed this as completed Apr 21, 2022
calohmn added a commit that referenced this issue Apr 22, 2022
Signed-off-by: Carsten Lohmann <[email protected]>
calohmn added a commit to bosch-io/hono that referenced this issue May 4, 2022
Supporting the W3C Trace Context/Baggage specifications
should be sufficient. Relates to eclipse-hono#3190.

Signed-off-by: Carsten Lohmann <[email protected]>
calohmn added a commit to bosch-io/hono that referenced this issue May 4, 2022
Supporting the W3C Trace Context/Baggage specifications
should be sufficient. Relates to eclipse-hono#3190.

Signed-off-by: Carsten Lohmann <[email protected]>
calohmn added a commit that referenced this issue May 4, 2022
Supporting the W3C Trace Context/Baggage specifications
should be sufficient. Relates to #3190.

Signed-off-by: Carsten Lohmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A request for adding new functionality to Hono help wanted Issues that we would welcome any help from (new) contributors with Tracing
Projects
None yet
Development

No branches or pull requests

2 participants