Split up command router modules #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection-base and client-device-connection-infinispan. Unit tests run.
…nto client-device-connection-base module. Unit tests run.
…e and services/command-router-infinispan. Unit tests and integration tests run.
StFS
requested review from
calohmn,
dejanb,
kaniyan and
sophokles73
as code owners
This was referenced Apr 3, 2024
|
Addresses #3532 |
sophokles73
requested changes
Apr 11, 2024
...est/java/org/eclipse/hono/deviceconnection/common/CommonCacheQuarkusPropertyBindingTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/eclipse/hono/deviceconnection/common/CommonCacheQuarkusPropertyBindingTest.java
Outdated
Show resolved
Hide resolved
...uter-infinispan/src/main/java/org/eclipse/hono/commandrouter/infinispan/app/Application.java
Show resolved
Hide resolved
...uter-infinispan/src/main/java/org/eclipse/hono/commandrouter/infinispan/app/Application.java
Outdated
Show resolved
Hide resolved
…org/eclipse-hono into split_command_router_modules
sophokles73
reviewed
Apr 17, 2024
sophokles73
requested changes
Apr 29, 2024
sophokles73
reviewed
Apr 30, 2024
Co-authored-by: Kai Hudalla <[email protected]>
Co-authored-by: Kai Hudalla <[email protected]>
…and then pushing them in the second
…le to provided scope, remove the optional option and remove exclusion rule
sophokles73
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is preparation for adding a redis backed command-router.
It consists of the following changes:
client-device-connection-infinispanmodule intoclient-device-connection-baseandclient-device-connection-infinispanmodules.-basemodule got refactored and their package name changes fromorg.eclipse.hono.deviceconnection.infinispan.clienttoorg.eclipse.hono.deviceconnection.commonQuarkusPropertyBindingTestclass got split into two:CommonCacheQuarkusPropertyBindingTestandRemoteCacheQuarkusPropertyBindingTestvertx-web, it turned out to be sufficient to depend onvertx-core). TODOs were added to get feedback on whether dependencies should only be declared in the-basemodule or whether they should be repeated in the-infinispanmodule.services/command-routermodule was split intoservices/command-router-baseandservices/command-router-infinispan.command-router-basemodule contains the vast majority of the code but the creation of a docker image was removed from that module.Applicationclass was converted to an abstract class to be implemented in descendant modules and namedAbstractApplicationaccordingly.DeviceConnectionInfoProducerclass was removed from the base module to be implemented in descendant modules.command-router-infinispanmodule contains the docker image creation. It also implements aInfinispanDeviceConnectionInfoProducerand anApplicationclass (descendant ofAbstractApplication) in order to create an Infinispan based implementation of a command-router.