Small checks and behavior differences for refactorings and assists #921
Conversation
| @@ -161,7 +161,7 @@ public RefactoringStatus checkActivationBasics(CompilationUnit rootNode) throws | |||
| RefactoringStatus result= new RefactoringStatus(); | |||
| fRootNode= rootNode; | |||
|
|
|||
| fAnalyzer= new SurroundWithTryCatchAnalyzer(fCUnit, fSelection); | |||
| fAnalyzer= new SurroundWithTryCatchAnalyzer(fCUnit, fSelection, true); | |||
There was a problem hiding this comment.
I think this needs to be a preference which jdt-ls can set to true by default and false otherwise. I think there are scenarios where a user would want to handle the exception for the method (e.g. to log something that isn't ever supposed to happen and a similar-type exception is actually expected in subsequent code). Removing the case forces the user have to add it manually vs deleting it if it is extraneous.
There was a problem hiding this comment.
Rob addressed this by introducing a new field in the class.
robstryker
force-pushed
the
jdtLsRequiredChanges1
branch
from
eef54d5
to
f68f218
Compare
|
Reverted the test changes and behavior. Since this is delayed, I will keep making any changes necessary for jdt.ls. Marking as draft. |
robstryker
force-pushed
the
jdtLsRequiredChanges1
branch
from
3354e42
to
5c53284
Compare
robstryker
force-pushed
the
jdtLsRequiredChanges1
branch
6 times, most recently
from
4895d87
to
704f04c
Compare
…r headless consumers (jdt.ls) Signed-off-by: Rob Stryker <[email protected]>
robstryker
force-pushed
the
jdtLsRequiredChanges1
branch
from
704f04c
to
a07eddc
Compare
There was a problem hiding this comment.
Change looks fine to me. This is mainly adding some protected classes allowing for some possible customization in refactoring behaviour.
My only concern was about the code where you retrieve only the first element of a composite change. However, looking into the (2) implementations of RefactoringCorrectionProposalCore, none appear to be returning a composite change. Furthermore looking at most classes that implement Refactoring, they seem to be returning a CompilationUnitChange, which is a TextChange.
...org/eclipse/jdt/internal/ui/text/correction/proposals/RefactoringCorrectionProposalCore.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rob Stryker <[email protected]>
Part 1
There will be 2 test failures but i forget what they are so I'll let Jenkins discover it and fix them.
What it does
How to test
Author checklist