No need to publish diagnostics in BuildWorkspaceHandler

[testforstephen]

Signed-off-by: Jinbo Wang [email protected]

WorkspaceDiagnosticsHandler.java is listening to resource change event, any time the build job changes (add or remove) the problem markers of the resources under the target project, the handler will sync diagnostics to the client. So it's unnecessary for the BuildWorkspaceHandler to clean up the project level diagnostics before building.

[snjeza]

test this please

[snjeza]

Related issue: #1284

[fbricon]

this was initially added to fix redhat-developer/vscode-java#608. Have you checked what happens with this PR?

[testforstephen]

In the original PR redhat-developer/vscode-java#608, the build handler will clean up project level diagnostics before building, but it also has logic to republish all diagnostics to client after building. The entire logic is symmetrical.

But some time later, the publish diagnostics logic is removed from the build handler. See the PR #829. If we still keep cleaning up the project level before build, trigger an incremental build actually won't duplicate report the existing project level errors to WorkspaceDiagnosticsHandler, so the client will probably lose some project level errors.

I think WorkspaceDiagnosticsHandler should be the only entry to sync build result to client.

[testforstephen]

A typical reproduce steps:

1. Open an android gradle project leakcanary in vscode.
2. After the LS is ready, the PROBLEMS view will show project level error.
3. Manually Force incremental build, you will see all errors gone from PROBLEMS view.

[snjeza]

test this please

[fbricon]

Thanks @testforstephen!