Improve SemanticTokensCommandTest #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
SemanticTokensCommandTestin the following ways:StringBuilderto generate source files.@fbricon does this PR address your comment on #1511? I was thinking about asserting that the source files had the same tokens as when compiled into class files, which feels like a more sturdy approach. However, as I am not too familiar with the Eclipse JDT APIs yet, I couldn't figure out an easy way to trigger a compile of the source files used in the test. If you know a way, I could implement that behavior, but maybe the test case for the library is good enough?