Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced IBuildSupport usage to support other build tools such as bazel #1694

Merged
merged 4 commits into from
Apr 14, 2021

Conversation

LeonovecSergey
Copy link
Contributor

Enhanced IBuildSupport usage to support other build tools such as bazel

Based on #1674

Signed-off-by: Siarhei Leanavets [email protected]

@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

@fbricon
Copy link
Contributor

fbricon commented Mar 18, 2021

add to whitelist

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments based on the change. Are these the only changes needed in JDT-LS to start supporting Bazel ?

@LeonovecSergey LeonovecSergey force-pushed the ibuildsupport branch 2 times, most recently from 78e02c5 to 8a3b615 Compare March 28, 2021 16:13
@LeonovecSergey
Copy link
Contributor Author

Hi @rgrunber,
The PR has been changed, but your comments are not included here.
Could you clarify your comments considering my answers

@rgrunber
Copy link
Contributor

rgrunber commented Apr 7, 2021

Hi @rgrunber,
The PR has been changed, but your comments are not included here.
Could you clarify your comments considering my answers

Thanks, I'll have another look. Apologies for the delay.

@fbricon
Copy link
Contributor

fbricon commented Apr 12, 2021

@rgrunber would be nice to have this one for 1.0

Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just some minor comments.

Signed-off-by: Siarhei Leanavets <[email protected]>
…ich build support we want to check against the project.

Signed-off-by: Siarhei Leanavets <[email protected]>
Signed-off-by: Siarhei Leanavets <[email protected]>
@LeonovecSergey
Copy link
Contributor Author

Overall looks good. Just some minor comments.

Hi @testforstephen , thanks for the review. I have no idea why ProjectsManagerTest.testCancelUpdateJob is not working because on my laptop the build is fine.

@testforstephen
Copy link
Contributor

test this please

@LeonovecSergey
Copy link
Contributor Author

test this please
Everything is fine after restarting Jenkins Pipeline

@fbricon fbricon merged commit d7a0f3c into eclipse-jdtls:master Apr 14, 2021
@fbricon
Copy link
Contributor

fbricon commented Apr 14, 2021

Thanks @LeonovecSergey

@testforstephen testforstephen added this to the Mid April 2021 milestone Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants