Show field type when generating accessors #2093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
reviewed
May 18, 2022
There was a problem hiding this comment.
Change looks good to me. I tried in particular to see if an unresolved type might result in some null value but seems like the type is just returned. Generics also work as expected.
I would add to GenerateAccessorsHandlerTest (either modifying existing tests or creating a new one) as typeName is not currently tested there.
After that, feel free to merge.
|
@rgrunber Sure. I'll add some checks on |
|
I think @snjeza 's buildship update will also fix the test failure from https:/eclipse/eclipse.jdt.ls/pull/2095/files#diff-081b41239a5c9e26fef6498db45e10891589f61bfb9122f6093a8e672c40034b . |
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: Shi Chen <[email protected]>
|
@rgrunber I have rebased this branch due to the conflicts and addressed the comments. |
testforstephen
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to redhat-developer/vscode-java#2459
Signed-off-by: Shi Chen [email protected]