Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for array type completions #2610

Merged
merged 2 commits into from
May 15, 2023

Conversation

gayanper
Copy link
Contributor

Fixes : #2609

This uses the new feature introduced into jdt.core eclipse-jdt/eclipse.jdt.core#507

@gayanper gayanper force-pushed the array_completions branch 2 times, most recently from bc03eb5 to d15348f Compare April 19, 2023 18:05
@gayanper gayanper marked this pull request as ready for review April 20, 2023 18:26
@gayanper
Copy link
Contributor Author

@rgrunber @jdneo @testforstephen @snjeza Let me know what you think about this change.

@snjeza snjeza self-requested a review April 20, 2023 19:07
@fbricon
Copy link
Contributor

fbricon commented Apr 24, 2023

I'm confused. Looks like it works for String[] and some objects. But not int[], boolean[] (and I assume other primitives)or the current class being edited, like:

public class Meh {

  public static void main(String[] args) {
    Meh[] m = new |
  }
}

Screenshot 2023-04-24 at 10 34 32

@gayanper
Copy link
Contributor Author

I'm confused. Looks like it works for String[] and some objects. But not int[], boolean[]

I will check it in jdt.core completion logic.

(and I assume other primitives)or the current class being edited, like:

public class Meh {

  public static void main(String[] args) {
    Meh[] m = new |
  }
}
Screenshot 2023-04-24 at 10 34 32

This i need to check, probably a bug in jdt.core.

@gayanper
Copy link
Contributor Author

gayanper commented May 9, 2023

I'm confused. Looks like it works for String[] and some objects. But not int[], boolean[]

I will check it in jdt.core completion logic.

(and I assume other primitives)or the current class being edited, like:

public class Meh {

  public static void main(String[] args) {
    Meh[] m = new |
  }
}
Screenshot 2023-04-24 at 10 34 32

This i need to check, probably a bug in jdt.core.

All above issues are fixed now in latest i-builds of jdt.core

- add more tests
- update target to include latest jdt.core array completion fixes.
@fbricon fbricon merged commit 0331b07 into eclipse-jdtls:master May 15, 2023
@fbricon
Copy link
Contributor

fbricon commented May 15, 2023

@gayanper thanks for this patch, that was a really needed enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for array completions instead of just type completions for array type receivers
4 participants