Add new API 'onWillUpdate()' to IBuildSupport #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jdneo
commented
Sep 6, 2023
jdneo
commented
- A new API 'onWillUpdate()' is added to IBuildSupport, which can be used to do some preparation work before updating the project configuration. For example: For the Build Server support, send a reload request to Build Server, then do the real update task in 'update()'.
- When a bunch of projects need to be updated, extract out the invocation of 'registerWatchers()' and 'updateEncoding()'. See: ProjectsManager#updateProjects(Collection, boolean force).
jdneo
changed the title
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/IBuildSupport.java
Outdated
Show resolved
Hide resolved
- A new API 'onWillUpdate()' is added to IBuildSupport, which can be used to do some preparation work before updating the project configuration. For example: For the Build Server support, send a reload request to Build Server, then do the real update task in 'update()'. - When a bunch of projects need to be updated, extract out the invocation of 'registerWatchers()' and 'updateEncoding()'. See: ProjectsManager#updateProjects(Collection<IProject>, boolean force). Signed-off-by: Sheng Chen <[email protected]>
Signed-off-by: Sheng Chen <[email protected]>
testforstephen
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.