Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jakarta websocket from 2.0.0 to 2.1.0 #661

Closed
wants to merge 1 commit into from

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Sep 8, 2022

it allows to be compatible with latest Tyrus RFC implementation 2.1.0 see https://jakarta.ee/specifications/websocket/2.1/ and https:/eclipse-ee4j/tyrus/releases/tag/2.1.0
Note:

it allows to be compatible with latest Tyrus RFC implementation 2.1.0
see https://jakarta.ee/specifications/websocket/2.1/ and
https:/eclipse-ee4j/tyrus/releases/tag/2.1.0

Signed-off-by: Aurélien Pupier <[email protected]>
@eclipse-lsp4j-bot
Copy link

Can one of the admins verify this patch?

@cdietrich
Copy link
Contributor

How is the orbit side of this gonna be addressed
https:/eclipse/lsp4j/blob/main/releng/releng-target/lsp4j.target.target

@HannesWell
Copy link
Contributor

I would like to suggest to replace InstallableUnit-Location that contains Jakarta websocket, guava and gson with a corresponding Maven target.

This would allow you to fetch those artifacts from Maven Central without the need to maintain/wait for Orbit.
If you agree I can create a PR.

@cdietrich
Copy link
Contributor

we might to do
#529
first.
this gets rid of guava as runtime dependency
(needed as compile dep only)

@jonahgraham
Copy link
Contributor

I am quite keen on what @merks has been working on in https://download.eclipse.org/oomph/simrel-maven/ too.

@HannesWell
Copy link
Contributor

As you prefer, both sounds good.
Nevertheless I expect the change a Maven target to be a simple local Change in the target File. It would have the Advantage that it can be done now.

And one glory day we maybe even get automated Updates via dependabot:
dependabot/dependabot-core#4682

If you later still prefer a Single Location for 3ed Party deps, switching to Ed's solution should be easy too.
I think that it is a valid and good solution, but Maven Targets+dependabot would probably be more Direct.

@jonahgraham
Copy link
Contributor

Ok. If that works we'll take it. I have no objection to the maven in target, but it needs pgp setup too for the project and may need tycho version bump too.

@jonahgraham
Copy link
Contributor

We now consume the latest jakarta websocket version from Orbit - see #791

This change is sort of orthogonal as it sets the minimum version. Should we make the minimum 2.1.1 as that is the version we get from Orbit, and the latest version on Maven Central (its the same jar in both places BTW - its just that Orbit makes it nicely into a p2 site)

@jonahgraham
Copy link
Contributor

I don't think we need to change the minimum version as I don't think we have requirements on newer version. If needed, please rebase the commit and reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants