Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply a ToStringBuilder in common location #798

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

jonahgraham
Copy link
Contributor

When the dependency on xbase.lib was removed in #529 it put the implicit requirement that there is a class called ToStringBuilder in a sub-package of the xtend class called util.

This change provides the ToStringBuilder in an util package in the org.eclipse.lsp4j.jsonrpc bundle so that consumers of LSP4J do not need to copy ToStringBuilder into their own source code.

Fixes #742

@jonahgraham
Copy link
Contributor Author

@eclipse-lsp4j/technology-lsp4j-committers if someone has time to review this and weigh in on whether it should make it into 0.22.0 that I will build tomorrow that will be great.

Copy link
Contributor

@pisv pisv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonahgraham Thank you very much for taking care of it!

The patch looks fine to me and safe enough to release it sooner rather than later 👍

pisv added a commit that referenced this pull request Feb 13, 2024
This is a follow-up to #798, which handles `Preconditions` similarly to `ToStringBuilder`.

See #742 for detailied discussion.
pisv added a commit that referenced this pull request Feb 13, 2024
This is a follow-up to #798, which handles `Preconditions` similarly to
`ToStringBuilder`.

See #742 for detailed discussion.
When the dependency on xbase.lib was removed in #529 it put the
implicit requirement that there is a class called ToStringBuilder
in a sub-package of the xtend class called `util`.

This change provides the ToStringBuilder in an util package
in the org.eclipse.lsp4j.jsonrpc bundle so that consumers
of LSP4J do not need to copy ToStringBuilder into their
own source code.

Fixes #742
@jonahgraham jonahgraham added this to the 0.22.0 milestone Feb 13, 2024
@jonahgraham jonahgraham merged commit 22dae55 into main Feb 13, 2024
7 of 8 checks passed
@jonahgraham jonahgraham deleted the jonah/fix-to-string branch February 13, 2024 13:53
jonahgraham pushed a commit that referenced this pull request Feb 13, 2024
This is a follow-up to #798, which handles `Preconditions` similarly to
`ToStringBuilder`.

See #742 for detailed discussion.
jonahgraham pushed a commit that referenced this pull request Feb 13, 2024
This is a follow-up to #798, which handles `Preconditions` similarly to
`ToStringBuilder`.

See #742 for detailed discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid generation of @JsonRpcData when using lsp4j 0.21 and xtend 2.31.0
2 participants