Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2Eclipse gets stuck in endless update loop #665

Merged
merged 1 commit into from
May 3, 2022

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented May 3, 2022

Fix #123

Lets see if simple things just work...

@laeubi
Copy link
Member Author

laeubi commented May 3, 2022

@mickaelistria this has solved my endless cycle but two tests complain, can you take a look what these tests are missing or what feature they depend on so I can try to enhance the solution?

@mickaelistria
Copy link
Contributor

Those tests are important. I think you can reproduce them manually to get a sense of what are the bad effects of your proposal. Basically, in some cases, some projects really need to be processed multiple times and your code skips that. The condition to skip a refresh needs to be narrower.

@laeubi
Copy link
Member Author

laeubi commented May 3, 2022

what are the bad effects

Stuck in an endless cycle is (for me) much more bad :-)

The condition to skip a refresh needs to be narrower.

I'll try a more sophisticated check ... :-\

Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems quite good!

@laeubi
Copy link
Member Author

laeubi commented May 3, 2022

If you think that it don't harm I'd like to merge this, maybe it will need improvements but I can only check for sure next time the build-loop occurs again ...

@mickaelistria mickaelistria merged commit 026330e into eclipse-m2e:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

M2Eclipse gets stuck in endless update loop
2 participants