(0.44) Transform new converter call to arraytranslate #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringCoding.implEncodeAsciiArray is a renamed version of US_ASCII/Encoder.encodeASCII, which is a recognized method. This commit introduces infrastructure to enable inlining of implEncodeAsciiArray like it is done for encodeASCII.
dchopra001
requested review from
pshipton
and removed request for
vijaysun-omr
dchopra001
changed the title
TR_disableImplEncodeAsciiArray was added to disable arraytranslate transformation of the StringCoding.implEncodeAsciiArray method. This commit removes the use of this variable as it is not needed, and the preexisting -Xjit:disableConverterReducer option provides an almost similar granularity of control in disabling this transformation.
pshipton
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringCoding.implEncodeAsciiArray is a renamed version of US_ASCII/Encoder.encodeASCII, which is a recognized method. This commit introduces infrastructure to enable inlining of implEncodeAsciiArray like it is done for encodeASCII.
Double delivery of eclipse/omr#7271 and eclipse/omr#7276