Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatting issues #109

Merged
merged 1 commit into from
May 8, 2024
Merged

Formatting issues #109

merged 1 commit into from
May 8, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented May 8, 2024

Some latest commits entered with wrong formatting.

@cstamas
Formatting issues
937b3a4 
Some latest commits entered with wrong formatting.
@cstamas cstamas requested review from mcculls and kwin May 8, 2024 07:25
@cstamas cstamas self-assigned this May 8, 2024
kwin
kwin approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@kwin kwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should fail the build in case of violation (at least optionally with a profile execute spotless:check)

@cstamas cstamas merged commit 02d39b8 into master May 8, 2024
12 checks passed
@cstamas cstamas deleted the formatting branch May 8, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwin kwin kwin approved these changes

@mcculls mcculls Awaiting requested review from mcculls

Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cstamas @kwin