You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently all proposals for code actions are inherited from CUCorrectionProposal including the conversion logic. e.g. CodeActionHandler, QuickFixProcessor
According to definition of CUCorrectionProposal, it is
A proposal for quick fixes and quick assists that work on a single compilation unit.
And as it overrides the createChange() with a final modifier, only text changes are allowed for the proposal.
It doesn't suit for more complicated fixes like "create a new type", which involves resouce changes.
BTW current implementation of rename file proposal is not proper. Renaming a file involves a ResouceChange, so the corresponding proposal should not be CUCorrectionProposal.
I think we should do some refactoring work to support other kind of ChangeCorrectionProposal, and add corresponding conversion logic for them.
The text was updated successfully, but these errors were encountered:
Currently all proposals for code actions are inherited from
CUCorrectionProposal
including the conversion logic. e.g. CodeActionHandler, QuickFixProcessorAccording to definition of
CUCorrectionProposal
, it isAnd as it overrides the
createChange()
with a final modifier, only text changes are allowed for the proposal.It doesn't suit for more complicated fixes like "create a new type", which involves resouce changes.
BTW current implementation of rename file proposal is not proper. Renaming a file involves a ResouceChange, so the corresponding proposal should not be
CUCorrectionProposal
.I think we should do some refactoring work to support other kind of
ChangeCorrectionProposal
, and add corresponding conversion logic for them.The text was updated successfully, but these errors were encountered: