Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the location check back when loading bundles #1286

Closed
jdneo opened this issue Nov 21, 2019 · 0 comments · Fixed by #1287
Closed

Add the location check back when loading bundles #1286

jdneo opened this issue Nov 21, 2019 · 0 comments · Fixed by #1287
Labels

Comments

@jdneo
Copy link
Contributor

jdneo commented Nov 21, 2019

In #1253, I removed the location check when loading bundle, which means when loading bundles, if there is already a bundle with the same version installed/started, all the bundles with the same version will be ignored.

This is fine for the common users, but it may have some problems for the developers who develop Java LS extensions.

For example, when launching the extension in dev mode for the Java Debugger or Java Test Runner, since the bundles have no qualifier in version, so the developing bundles won't be loaded unless bump-up the version, or clean the LS cache, which is not convenient.

I think I should add the location check back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants