Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some refactors are missing when the location has diagnostics #1642

Closed
jdneo opened this issue Jan 13, 2021 · 0 comments · Fixed by #1643
Closed

Some refactors are missing when the location has diagnostics #1642

jdneo opened this issue Jan 13, 2021 · 0 comments · Fixed by #1643
Assignees
@jdneo
Labels
bug
Milestone
Mid January 2021

Comments

@jdneo
Copy link
Contributor

jdneo commented Jan 13, 2021

When the location has diagnostics from other extension, the Java Language Server will take it as errors and skip resolving some of the refactors:https:/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corrections/RefactorProcessor.java#L140

Here is a gif to illustrate the issue:

refactor-bug.mp4

I think we need to check the source of the errors and only skip those refactors when it do have errors from the Java Language Server itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdneo jdneo

Labels
bug
Projects
None yet
Milestone
Mid January 2021
Development

Successfully merging a pull request may close this issue.

Filter the source of the diagnostics when resolving refactoring proposals jdneo/eclipse.jdt.ls
2 participants
@jdneo @testforstephen