JDTLS attempts to start fragments

[guw]

From the client log file:

    'Contains: Bundle startup failed reference:file:/....logback.jar\n' +
    'org.osgi.framework.BundleException: Invalid operation on a fragment. osgi.identity; type="osgi.fragment"; version:Version="..."; osgi.identity="....logback" [id=123]\n' +
    '\tat org.eclipse.osgi.container.Module.checkFragment(Module.java:543)\n' +
    '\tat org.eclipse.osgi.container.Module.start(Module.java:426)\n' +
    '\tat org.eclipse.osgi.internal.framework.EquinoxBundle.start(EquinoxBundle.java:445)\n' +
    '\tat org.eclipse.jdt.ls.core.internal.handlers.BundleUtils.startBundles(BundleUtils.java:280)\n' +
    '\tat org.eclipse.jdt.ls.core.internal.handlers.BundleUtils.loadBundles(BundleUtils.java:167)\n' +
    '\tat org.eclipse.jdt.ls.core.internal.handlers.InitHandler.handleInitializationOptions(InitHandler.java:100)\n' +
    '\tat org.eclipse.jdt.ls.core.internal.handlers.BaseInitHandler.initialize(BaseInitHandler.java:64)\n' +
    '\tat org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer.initialize(JDTLanguageServer.java:275)\n' +
    '\tat java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\n' +

Looks like JDTLS needs some logic to not attempt to start fragments.

[snjeza]

JDT LS includes one fragment. See
https:/eclipse/eclipse.jdt.ls/blob/24c3892b7761a81a00bf0361153f3b0bf40219fb/org.eclipse.jdt.ls.logback.appender/META-INF/MANIFEST.MF#L6

We should not skip it
@guw Could you try to clean your global storage

$ rm -rf ~/.config/Code/User/globalStorage/

[guw]

@snjeza The fragment you mentioned is not going through that code path. This is only called for extensions contributing additional bundles to JDTLS. That's why you don't get that error for the fragment included in JDTLS. You would get it otherwise because fragments cannot be started. It's impossible in OSGi.

However, this is an interesting case. The host (where the fragment is attaching to) might need to be re-resolved for the fragment to become attached. Thus, extensions should probably not expect fragments to work.