Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ImplementationProvider Support #556

Closed
fbricon opened this issue Feb 16, 2018 · 3 comments
Closed

Add ImplementationProvider Support #556

fbricon opened this issue Feb 16, 2018 · 3 comments
Assignees
@fbricon
Labels
enhancement priority/P2
Milestone
End August 2018

Comments

@fbricon
Copy link
Contributor

fbricon commented Feb 16, 2018

See microsoft/language-server-protocol#156
and redhat-developer/vscode-java#446

The protocol has not been updated yet. We need to add a protocol extension (in lsp4j?)
@rcjsuen
Copy link
Contributor

rcjsuen commented Feb 27, 2018

The textDocument/implementation request got added to the protocol last Thursday (2018-02-27).

lsp4j will need to be updated to reflect the new specification.

@gorkem
Copy link
Contributor

gorkem commented Apr 14, 2018

Filed eclipse-lsp4j/lsp4j#178 for LSP4J

@yyoncho yyoncho mentioned this issue Jun 22, 2018
Closed
@fbricon
Copy link
Contributor Author

fbricon commented Jun 22, 2018

See protocol spec: https:/Microsoft/language-server-protocol/blob/gh-pages/specification.md#goto-implementation-request-leftwards_arrow_with_hook

@fbricon fbricon self-assigned this Jun 27, 2018
@fbricon fbricon added this to the End July 2018 milestone Jul 11, 2018
@fbricon fbricon mentioned this issue Jul 11, 2018
Closed
17 tasks
fbricon added a commit to fbricon/eclipse.jdt.ls that referenced this issue Aug 25, 2018
@fbricon
Add textdocumenmt/implementation support.
6498c50 
java.lang.Object is treated as a special case. Because of its large type
hierarchy, implementation location is not computed from reading all
files. Instead a default location at 0,0 will always be returned.

Fixes eclipse-jdtls#556

Signed-off-by: Fred Bricon <[email protected]>
@fbricon fbricon mentioned this issue Aug 25, 2018
Merged
fbricon added a commit that referenced this issue Aug 27, 2018
@fbricon
Add textdocumenmt/implementation support.
bb595f8 
java.lang.Object is treated as a special case. Because of its large type
hierarchy, implementation location is not computed from reading all
files. Instead a default location at 0,0 will always be returned.

Fixes #556

Signed-off-by: Fred Bricon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbricon fbricon

Labels
enhancement priority/P2
Projects
None yet
Milestone
End August 2018
Development

No branches or pull requests
3 participants
@gorkem @fbricon @rcjsuen