Cancel init or update workspace job of removed rootPaths #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Poytr1 <[email protected]>
|
@Poytr1 Could you, please, add some unit tests? |
Signed-off-by: Poytr1 <[email protected]>
Poytr1
force-pushed
the
pcxu_cancel_before_remove
branch
from
de9c385
to
aed1e27
Compare
Signed-off-by: Poytr1 <[email protected]>
Poytr1
force-pushed
the
pcxu_cancel_before_remove
branch
from
3bd5853
to
0594378
Compare
|
@snjeza Done! |
snjeza
approved these changes
Jun 13, 2019
fbricon
requested changes
Jun 13, 2019
|
|
||
| @Before | ||
| public void setup() throws Exception { | ||
| server = new JDTLanguageServer(projectsManager, preferenceManager); |
There was a problem hiding this comment.
you need to store the workspace autobuilding value
| server.disconnectClient(); | ||
| JavaLanguageServerPlugin.getInstance().setProtocol(null); | ||
| try { | ||
| projectsManager.setAutoBuilding(true); |
There was a problem hiding this comment.
restore workspace's initial autobuild value
Signed-off-by: Poytr1 <[email protected]>
fbricon
approved these changes
Jun 18, 2019
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Poytr1 [email protected]
When we call
java/didChangeWorkspaceFolders, we may remove some workspaces. However, when the removed workspace is still in the initialization phase, the initialize/update workspace job is still at WAITING status or RUNNING status. We have not canceled these jobs, and they will still execute in the background, occupying resources. The potential problem is that if I delete this workspace, I might get an exception from these jobs.This PR is used to add a new family(rootpaths) for the initialize and update jobs, so that you can find these background workspace jobs for initializing the workspace based on removed rootpaths and try to cancel them.
@fbricon How do you think about this?