Only enable preview features for the latest available JDK #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fred Bricon <[email protected]>
snjeza
approved these changes
Oct 3, 2019
|
Is there a discussion/issue/ticket somewhere that explains the reasoning behind this change? |
|
Never mind, found it: https://bugs.eclipse.org/bugs/show_bug.cgi?id=549258 Eclipse uses its own Java compiler, ECJ, instead of an OpenJDK-based one. Supporting preview features from old Java versions is more than the ECJ team are up for. I wish it were possible for ECJ to support preview features from past LTS releases. If we use OpenJDK we can get an LTS with a version of Panama that is nearly indistinguishable from the finalized version. With ECJ we have to choose between LTS and Panama. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See redhat-developer/vscode-java#1086