Add final modifier where possible

[NikolasKomonen]

Fixes redhat-developer/vscode-java#774

One thing that can be improved is the message "Add final", but that relies on
a change from jdt code.

Signed-off-by: Nikolas Komonen [email protected]

[snjeza]

test this please

[snjeza]

test this please
with unit tests or by hand? Both are working for me.

@NikolasKomonen 'test this please' is a request for Jenkins - https://ci.eclipse.org/ls/job/jdt-ls-pr

[snjeza]

@NikolasKomonen could you check the following test - org.eclipse.jdt.ls.core.internal.handlers.DocumentLifeCycleHandlerTest.testRemoveDeadCodeAfterIf()
See https://ci.eclipse.org/ls/job/jdt-ls-pr/1681/testReport/org.eclipse.jdt.ls.core.internal.handlers/DocumentLifeCycleHandlerTest/testRemoveDeadCodeAfterIf/

[fbricon]

The behavior is really surprising, since, it makes all variables in the file final. So the label is definitely confusing here.
Either we change the behavior to only apply to the selected variable, or we need to change the label to "Make all variables final"

[NikolasKomonen]

@fbricon I've submitted the issue to fix this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=552490
They just need to swap the message with a better one.

[NikolasKomonen]

@fbricon resolved the changes

[snjeza]

test this please

[snjeza]

test this please

[fbricon]

@Eskibear can you please check this change is compatible with the current refactoring of code actions?

[Eskibear]

In this PR, it creates a FixCorrectionProposal which is by default of kind 'quickfix'. A code action is a 'quickfix' if there's a corresponding diagnotic information like an error/warning/info. If there is not, personally I think it's more like a 'quickassist', then it should stay here in QuickAssistProcessor.

My next step is to move almost all proposals (except getAssignParamToFieldProposals and getAssignAllParamsToFieldsProposals) from QuickAssistProcessor into RefactorProcessor, as they are actually of kind 'refactor'.

[fbricon]

there's no diagnostic, this applies to the whole class. So we can merge it?

[Eskibear]

No problem, it’s not conflicting with my work.

I suggest to change the kind to ‘quickassist’ or ‘source’(it sounds more like this kind, but in vscode it will only appear when you click SourceAction...) . Anyway it’s not conflicting, you can simply merge it and I can help change it later.

[fbricon]

ok thanks, @NikolasKomonen is only working part time, so I'll merge it now and let you do the necessary changes later