enable syntax mode when importing a partial folder of maven/gradle project #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@testforstephen can you please fix the merge conflict? |
…oject Signed-off-by: Jinbo Wang <[email protected]>
testforstephen
force-pushed
the
jinbo_syntaxmode
branch
from
3f6eba3
to
fdd9152
Compare
|
PR updated. |
fbricon
reviewed
Mar 30, 2020
| IPath srcPath = sourcePath.removeLastSegments(segments.size() -1 - index); | ||
| IPath container = srcPath.removeLastSegments(1); | ||
| return container.append("pom.xml").toFile().exists() | ||
| || container.append("build.gradle").toFile().exists(); |
There was a problem hiding this comment.
I'm not super fan of hardcoding Maven and Gradle specific things here, I think we can improve that by decoupling Build files discovery from the InvisibleProjectImporter, but it'll do for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jinbo Wang [email protected]
Fix redhat-developer/vscode-java#1275
When opening a partial folder from a maven/gradle project, because the classpath is incomplete, will report syntax errors only.