IBuildSupport extension point #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
…pport. Implement build support extension point. Signed-off-by: Siarhei Leanavets <[email protected]>
|
add to whitelist |
fbricon
requested changes
May 29, 2020
org.eclipse.jdt.ls.core/schema/org.eclipse.jdt.ls.core.buildSupport.exsd
Show resolved
Hide resolved
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Outdated
Show resolved
Hide resolved
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/MavenBuildSupport.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/IBuildSupport.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleBuildSupport.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/MavenBuildSupport.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/MavenBuildSupport.java
Outdated
Show resolved
Hide resolved
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Show resolved
Hide resolved
Signed-off-by: Siarhei Leanavets <[email protected]>
Signed-off-by: Siarhei Leanavets <[email protected]>
fbricon
requested changes
Jun 2, 2020
...e.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/managers/StandartProjectManagerTest.java
Outdated
Show resolved
Hide resolved
fbricon
requested changes
Jun 2, 2020
...lipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManager.java
Outdated
Show resolved
Hide resolved
...jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/managers/StandardProjectsManagerDummy.java
Outdated
Show resolved
Hide resolved
fbricon
reviewed
Jun 2, 2020
...e.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/managers/StandartProjectManagerTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Siarhei Leanavets <[email protected]>
|
Thabks @beginningineer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @fbricon ,
please take a look at a rough attempt to introduce extension point for IBuildSupport.
we need it for Bazel Build tool integration (previously discussed in #1404 (comment)).
looking forward for your comments!