Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to specify source paths for unmanaged folder #1658

Merged
merged 3 commits into from
Mar 9, 2021

Conversation

jdneo
Copy link
Contributor

@jdneo jdneo commented Feb 8, 2021

Resolve redhat-developer/vscode-java#1798. Related with redhat-developer/vscode-java#1799

This PR contains 3 major part changes:

  • Return the current source paths list when user sends the request Add/Remove folder to Java Source Path to the server. The client will use the returned result to update the workspace setting
  • Resolve and apply the classpath entries according to the current output path & source path setting when loading the invisible project
  • Resolve and apply the classpath entries according to the current output path & source path setting when the related preferences are changed

Signed-off-by: Sheng Chen [email protected]

Signed-off-by: Sheng Chen <[email protected]>
Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Expose source paths setting in VS Code for unmanaged folders
2 participants