Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatter profile options before applying #1675

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

CsCherrYY
Copy link
Contributor

@CsCherrYY CsCherrYY commented Mar 5, 2021

Will update formatter options to the newest version before applying them. This could work for many scenarios where deprecated formatter settings (in previous profile version) are ignored.

Fixes redhat-developer/vscode-java#1640

Signed-off-by: Shi Chen [email protected]

Signed-off-by: Shi Chen <[email protected]>
Copy link
Contributor

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@testforstephen testforstephen added this to the End March 2021 milestone Mar 30, 2021
@testforstephen testforstephen merged commit 99a34ff into eclipse-jdtls:master Mar 30, 2021
@CsCherrYY CsCherrYY deleted the formatterVersion branch April 6, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java code formatter rules is ignored
2 participants