Add support for month, day, hour, minute variables in typeComment. #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrunber
force-pushed
the
fix-2052
branch
2 times, most recently
from
a5b5779
to
f2dd7da
Compare
|
Looks like both JS and Java server side generated the wrong value for ${month} and ${day}. Here are the values by the server side type comment: The expected value should be 2021-8-18 11:18 |
...se.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/CodeTemplatePreferences.java
Outdated
Show resolved
Hide resolved
...se.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/CodeTemplatePreferences.java
Outdated
Show resolved
Hide resolved
- Fixes redhat-developer/vscode-java#2052 - Ensure that all single digit representations are 0-prefixed Signed-off-by: Roland Grunberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't mind leaving this for after the release.
Signed-off-by: Roland Grunberg [email protected]