java server refreshing the workspace (cleaning and building) for each restart

[snjeza]

Fixes redhat-developer/vscode-java#2222 and redhat-developer/vscode-java#2208

Signed-off-by: Snjezana Peco [email protected]

[jdneo]

Just curious, why do we need a clean build here?

[snjeza]

Because the JDT settings has been changed.

[testforstephen]

Just have a try on VS Code with eclipse.jdt.ls project itself.

Without the PR:
reloading eclipse.jdt.ls on VS Code took about 5 minutes to be thumb up.

With the PR:
reloading eclipse.jdt.ls on VS Code took about 3 minutes and 18 seconds to be thumb up.

Looks like it improves the performance of project reimport.

[snjeza]

Just have a try on VS Code with eclipse.jdt.ls project itself.

What OS have you used? Could you, please, try it on Linux?
See

• Windows 10 x64/macOS, open spring-boot/wildfly, it will always trigger full build after initialized after imported redhat-developer/vscode-java#793
• java server refreshing the workspace for each restart on Windows  redhat-developer/vscode-java#880
• Fix build on Windows #991

[snjeza]

It takes a few seconds to reload the eclipse.jdt.ls with the PR on Fedora 34.

[rgrunber]

I think this is worth getting in, given how much it improves re-opening a project. I occasionally still see the build happening on a simple re-opening of the project, but the "clean workspace" job is eliminated, so it seems worth it for that.

[testforstephen]

I tried on macOS. It spent much time on updating project, definitely there is still room to optimize the reload performance.

When you tried eclipse.jdt.ls on Linux, did you install vscode-pde extension? Without it, eclipse.jdt.ls project actually won't load successfully.

[snjeza]

When you tried eclipse.jdt.ls on Linux, did you install vscode-pde extension?

No, I didn't. I will check. Could you, please, test a maven/gradle/eclipse project?

[snjeza]

reloading eclipse.jdt.ls on VS Code took about 3 minutes and 18 seconds to be thumb up.

This is an upstream vscode-pde issue. I have created testforstephen/vscode-pde#37
You can speed up reloading eclipse.jdt.ls by adding the following property:

"java.jdt.ls.vmargs": "-Declipse.jdt.ls.skipGradleChecksums=true ..."

[testforstephen]

https:/eclipse/eclipse.jdt.ls/blob/282c35026d50c253572e60b17a55715e7f9cae2f/org.eclipse.jdt.ls.core/pom.xml#L34-L51

I saw we added a m2e tag <?m2e execute onConfiguration?> for this task, this looks like unnecessary because this task should only be used by CI jobs, not needed by the IDE m2e tools.

[snjeza]

I saw we added a m2e tag for this task, this looks like unnecessary because this task should only be used by CI jobs, not needed by the IDE m2e tools.

You are right. Could you, please, create a new issue and PR?

[testforstephen]

Try commenting out the m2e tag, and the reimport performance will drop to about 1 minutes.

I'll push a fix after the 1.1.0 version is released.

[snjeza]

I tried on macOS. It spent much time on updating project, definitely there is still room to optimize the reload performance.
When you tried eclipse.jdt.ls on Linux, did you install vscode-pde extension? Without it, eclipse.jdt.ls project actually won't load successfully.

@testforstephen could you, please, test https:/snjeza/vscode-test/raw/master/java-1.2.3.vsix

[testforstephen]

Try your java-1.2.4.vsix with -Djava.ls.doNotSetDefaultJVM=true on eclipse.jdt.ls, updating project configuration is a littler faster than before. I will find some time to review your PR implementation.

[snjeza]

@testforstephen java-1.2.4.vsix with -Djava.ls.doNotSetDefaultJVM=true takes a few seconds to reload the eclipse.jdt.ls on Fedora 34 and Windows 10.
Could you, please, attach your server log (java.trace.server: messages)?

[testforstephen]

I'm on macOS. Here is the log.
log.txt