Rename Gradle project name when conflict #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi Chen <[email protected]>
CsCherrYY
force-pushed
the
cs-duplicate-project-name
branch
from
4115fc8
to
5441b6f
Compare
|
@snjeza Yeah, I have rebased this PR, feel free to review :) |
snjeza
approved these changes
Aug 23, 2022
gayanper
pushed a commit
to gayanper/eclipse.jdt.ls
that referenced
this pull request
Sep 8, 2022
rename project name when duplicate regardless case Signed-off-by: Shi Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shi Chen [email protected]
related to microsoft/vscode-java-pack#1040
When we open a Gradle project having the same name in the rootfolder and subfolder, the language server will report the following error:
The root cause is that eclipse resource system doesn't allow the duplicate names, so the proposal here is that we can rename the project name with
${rootProject.name}-${project.path}when conflicts are detected. The new project name looks like this:TODOs: