Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discrepancy in completion between prefixed and default namespaces #311

Closed
NikolasKomonen opened this issue Mar 6, 2019 · 1 comment · Fixed by #478
Closed

Discrepancy in completion between prefixed and default namespaces #311

NikolasKomonen opened this issue Mar 6, 2019 · 1 comment · Fixed by #478
Assignees
@angelozerr
Labels
bug Something isn't working completion This issue or enhancement is related to completion support XSD
Milestone
v0.8.0

Comments

@NikolasKomonen
Copy link
Contributor

redhat-developer/vscode-xml#87
@NikolasKomonen NikolasKomonen added this to the v0.7.0 milestone May 22, 2019
@fbricon fbricon added bug Something isn't working completion This issue or enhancement is related to completion support XSD labels May 24, 2019
@NikolasKomonen
Copy link
Contributor Author

NikolasKomonen commented Jun 6, 2019 •
edited
Loading

This issue may be part of a larger issue for all Schema based completion.
I think this issue can be part of a major fix for Schema based completion

The problem is caused because the current completion implementation always goes to each Schema and retrieves all possible element completions. This is done here

What should happen is that, here, the Wildcard should start performing the task of gathering other Schema files' valid elements instead of how it is currently doing it.

@fbricon fbricon modified the milestones: v0.7.0, v0.8.0 Jun 10, 2019
angelozerr added a commit that referenced this issue Jun 28, 2019
@angelozerr
Discrepancy in completion between prefixed and default namespaces
f64681f 
Fix #311

Signed-off-by: azerr <[email protected]>
@angelozerr angelozerr mentioned this issue Jun 28, 2019
Merged
angelozerr added a commit that referenced this issue Jun 28, 2019
@angelozerr
Discrepancy in completion between prefixed and default namespaces
8f7c821 
Fix #311

Signed-off-by: azerr <[email protected]>
angelozerr added a commit that referenced this issue Jun 28, 2019
@angelozerr
Discrepancy in completion between prefixed and default namespaces
042ed19 
Fix #311

Signed-off-by: azerr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working completion This issue or enhancement is related to completion support XSD
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Discrepancy in completion between prefixed and default namespaces eclipse/lemminx
3 participants
@fbricon @angelozerr @NikolasKomonen