Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onTagText to IHoverParticipant (or extend IHoverParticipant) #609

Closed
AObuchow opened this issue Feb 6, 2020 · 8 comments · Fixed by #621
Closed

Add onTagText to IHoverParticipant (or extend IHoverParticipant) #609

AObuchow opened this issue Feb 6, 2020 · 8 comments · Fixed by #621
Assignees
Labels
Milestone

Comments

@AObuchow
Copy link
Member

AObuchow commented Feb 6, 2020

For the LemMinX/lsp4xml Maven extension, I would like to add support for hover request when hovering over text within a tag. Currently, IHoverParticipant only declares hovers for onTag, onAttributeName and onAttributeValue.
Since the interface is already in use, perhaps a IHoverParticipantExtension should be added, which would declare onTagText. This function would only be called when the child of a node contains only text content (and not another node/tag).

This is required for AObuchow/lsp4xml-extensions-maven#30 as well as other use cases. For a demo of the hover we are trying to implement, see this GIF.

@AObuchow AObuchow changed the title Add onTagText to IHoverParticipant Add onTagText to IHoverParticipant (or extend IHoverParticipant) Feb 6, 2020
@angelozerr
Copy link
Contributor

Totally agree with you. Any pr are welcome!

@angelozerr
Copy link
Contributor

Since the interface is already in use, perhaps a IHoverParticipantExtension should be added, which would declare onTagText.

No please not do that, the participant API are not frozen for the moment since we are not in 1.0.0 version

@AObuchow
Copy link
Member Author

AObuchow commented Mar 9, 2020

Since the interface is already in use, perhaps a IHoverParticipantExtension should be added, which would declare onTagText.

No please not do that, the participant API are not frozen for the moment since we are not in 1.0.0 version

Okay sounds good!
Will the 1.0.0 version occur with the first, new release of LemMinX? (Wanted to know how much time I have to get this in before the API freeze)

@angelozerr
Copy link
Contributor

Will the 1.0.0 version occur with the first,

Not for the moment, any PR are welcome!

@angelozerr
Copy link
Contributor

@AObuchow have you an idea when you could provide a PR?

@AObuchow
Copy link
Member Author

@angelozerr my next task is to work on this PR. As I haven't started yet, I'm not sure of the complexity of this task. Once I get started I'll have a better idea, and will hopefully be able to give a time estimate.

@angelozerr
Copy link
Contributor

@angelozerr my next task is to work on this PR.

Great!

It should be very cool if we could have this feature in the next release. But if it's not possible we will do that in an another release. Don't hesitate to ask me if you need some help.

AObuchow added a commit to AObuchow/lsp4xml that referenced this issue Mar 12, 2020
Add onTagText to IHoverParticipant, fix eclipse#609

Signed-off-by: Andrew Obuchowicz <[email protected]>
@AObuchow
Copy link
Member Author

It should be very cool if we could have this feature in the next release. But if it's not possible we will do that in an another release. Don't hesitate to ask me if you need some help.

Sounds good, it was actually a lot easier than I anticipated :) I'm optimistic the feature will be ready for the next release.

AObuchow added a commit to AObuchow/lsp4xml that referenced this issue Mar 12, 2020
Add onTagText to IHoverParticipant, fix eclipse#609

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit to AObuchow/lsp4xml that referenced this issue Mar 12, 2020
Add onTagText to IHoverParticipant, fix eclipse#609

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit to AObuchow/lsp4xml that referenced this issue Mar 12, 2020
Add onTagText to IHoverParticipant, fix eclipse#609

Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow added a commit to AObuchow/lsp4xml that referenced this issue Mar 12, 2020
Add onTagText to IHoverParticipant, fix eclipse#609

Signed-off-by: Andrew Obuchowicz <[email protected]>
angelozerr pushed a commit that referenced this issue Mar 13, 2020
Add onTagText to IHoverParticipant, fix #609

Signed-off-by: Andrew Obuchowicz <[email protected]>
@angelozerr angelozerr added this to the 0.11.0 milestone Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants