-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add onTagText to IHoverParticipant (or extend IHoverParticipant) #609
Comments
Totally agree with you. Any pr are welcome! |
No please not do that, the participant API are not frozen for the moment since we are not in 1.0.0 version |
Okay sounds good! |
Not for the moment, any PR are welcome! |
@AObuchow have you an idea when you could provide a PR? |
@angelozerr my next task is to work on this PR. As I haven't started yet, I'm not sure of the complexity of this task. Once I get started I'll have a better idea, and will hopefully be able to give a time estimate. |
Great! It should be very cool if we could have this feature in the next release. But if it's not possible we will do that in an another release. Don't hesitate to ask me if you need some help. |
Add onTagText to IHoverParticipant, fix eclipse#609 Signed-off-by: Andrew Obuchowicz <[email protected]>
Sounds good, it was actually a lot easier than I anticipated :) I'm optimistic the feature will be ready for the next release. |
Add onTagText to IHoverParticipant, fix eclipse#609 Signed-off-by: Andrew Obuchowicz <[email protected]>
Add onTagText to IHoverParticipant, fix eclipse#609 Signed-off-by: Andrew Obuchowicz <[email protected]>
Add onTagText to IHoverParticipant, fix eclipse#609 Signed-off-by: Andrew Obuchowicz <[email protected]>
Add onTagText to IHoverParticipant, fix eclipse#609 Signed-off-by: Andrew Obuchowicz <[email protected]>
Add onTagText to IHoverParticipant, fix #609 Signed-off-by: Andrew Obuchowicz <[email protected]>
For the LemMinX/lsp4xml Maven extension, I would like to add support for hover request when hovering over text within a tag. Currently, IHoverParticipant only declares hovers for
onTag
,onAttributeName
andonAttributeValue
.Since the interface is already in use, perhaps a
IHoverParticipantExtension
should be added, which would declareonTagText
. This function would only be called when the child of a node contains only text content (and not another node/tag).This is required for AObuchow/lsp4xml-extensions-maven#30 as well as other use cases. For a demo of the hover we are trying to implement, see this GIF.
The text was updated successfully, but these errors were encountered: