Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover for referenced entities #663

Closed
angelozerr opened this issue Apr 28, 2020 · 4 comments · Fixed by #726
Closed

Hover for referenced entities #663

angelozerr opened this issue Apr 28, 2020 · 4 comments · Fixed by #726
Assignees
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Apr 28, 2020

Given this XML file:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE article [
  <!ENTITY mdash "&#x2014;">
]>
<root>
  &mdash;
</root>

when &mdash; is hovered, we should see the same information than entities completion:

image

It should work for external entities too (entities declared in a DTD ).

@angelozerr angelozerr self-assigned this May 25, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 25, 2020
@angelozerr angelozerr removed the good first issue Good for newcomers label May 25, 2020
@angelozerr
Copy link
Contributor Author

@mickaelistria @AObuchow @Seiphon I need to change the IHoverParticipant API for onText because for entities hover, the range is not the full text range, so I need to return the entity range (ex : abcd&a|mp;efg -> I must return range of & and not the full range text).

I'm afraid that I must change the API. To be consistent with other on* method, I think I will return Hover too instead of String.

@AObuchow
Copy link
Member

@angelozerr this should be okay, just @mention me in the PR to change the API so I can get a heads up as to how things will need to be adjusted in LemMinX-Maven.

@angelozerr
Copy link
Contributor Author

@angelozerr this should be okay

Thanks for your answer and your understand. I will ping you as soon as my work will be merged (I hope this week).

@mickaelistria
Copy link
Contributor

FWIW, we'll stick to current release of LemMinX for 2020-06 anyway (both in Wild Web Developer and m2e), after 2020-06, we can adopt newer snapshots and APIs in those projects.

angelozerr added a commit to angelozerr/lemminx that referenced this issue May 25, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 26, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 26, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 26, 2020
@angelozerr angelozerr added this to the 0.12.0 milestone May 26, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 26, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 27, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 27, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 27, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 27, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 27, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 27, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 27, 2020
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 28, 2020
xorye pushed a commit that referenced this issue May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants