Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range formatting is ignoring the rest of the document's indentation #76

Closed
fbricon opened this issue Aug 27, 2018 · 4 comments · Fixed by #421
Closed

Range formatting is ignoring the rest of the document's indentation #76

fbricon opened this issue Aug 27, 2018 · 4 comments · Fixed by #421
Assignees
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Aug 27, 2018

When formatting a selection, the whole selection is formatted against the 1st column, ignoring the rest of the document's indentation. See:

xml-format-region

In Java for instance, the selection is also formatted against the rest of the document:

java-format-region

@fbricon fbricon added enhancement New feature or request formatting This issue or enhancement is related to formatting support labels Aug 27, 2018
@angelozerr angelozerr self-assigned this Aug 27, 2018
@angelozerr
Copy link
Contributor

I will fix it since I have already done that for completion.

@fbricon fbricon added the to do label Sep 5, 2018
@fbricon
Copy link
Contributor Author

fbricon commented Sep 14, 2018

@angelozerr are you still looking at that one or should we assign it to @NikolasKomonen. Because that makes range formatting almost useless

@angelozerr
Copy link
Contributor

I'm fixing #117 and after I will see it.

@fbricon
Copy link
Contributor Author

fbricon commented Sep 14, 2018

cool, thanks

@fbricon fbricon removed the to do label Nov 15, 2018
@fbricon fbricon added this to the v0.0.4 milestone Nov 15, 2018
@NikolasKomonen NikolasKomonen modified the milestones: v0.4.0, v0.5.0 Mar 1, 2019
@NikolasKomonen NikolasKomonen removed this from the v0.5.0 milestone Mar 15, 2019
@NikolasKomonen NikolasKomonen added this to the v0.7.0 milestone May 22, 2019
@xorye xorye self-assigned this Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request formatting This issue or enhancement is related to formatting support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants