Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename XSD/DTD generation code actions #807

Open
xorye opened this issue Jun 24, 2020 · 5 comments · Fixed by #809
Open

Rename XSD/DTD generation code actions #807

xorye opened this issue Jun 24, 2020 · 5 comments · Fixed by #809

Comments

@xorye
Copy link

xorye commented Jun 24, 2020

@fbricon 's idea:

For these code actions:

image

Rename each of them to match this format:

Bind to the generated XSD 'test.xsd' with xsi:noschemaLocation to Generate 'test.xsd' and bind with xsi:noschemaLocation.

After, we could add another code action if test.xsd exists: Bind to 'test.xsd' with xsi:noschemaLocation.

@angelozerr
Copy link
Contributor

+1

@xorye is there any chance that you work on this issue?

@xorye
Copy link
Author

xorye commented Jun 24, 2020

@angelozerr yes, I can look into this

@xorye
Copy link
Author

xorye commented Jun 25, 2020

For this issue:

  • Rename code actions
  • Add new code action for when the schema file already exists

@datho7561
Copy link
Contributor

@angelozerr do you think the second portion of this issue is worth pursuing? I know we were thinking of implementing a command that will bind to a schema that is passed by the client. (ie. the client provides a wizard to select the schema file, then calls a LemMinX command to bind the document to the schema). However, using a CodeAction in this scenario means nothing needs to be implemented on the client side.

@angelozerr
Copy link
Contributor

However, using a CodeAction in this scenario means nothing needs to be implemented on the client side.

The idea with CodeAction is to generate a CodeAction with a command id (only when client has the proper capability). This command id will used on client side to open a XSD files (This part could be managed by redhat-developer/vscode-xml#395 which will work with CodeLens).

In short I think we could split this issue in 2 isssues like explained #807 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants