Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate client/registerCapability for workspace/executeCommand #937

Closed
deathaxe opened this issue Nov 28, 2020 · 1 comment · Fixed by #938 or enxio/lsp4xml#102
Closed

Duplicate client/registerCapability for workspace/executeCommand #937

deathaxe opened this issue Nov 28, 2020 · 1 comment · Fixed by #938 or enxio/lsp4xml#102
Assignees
Labels
bug Something isn't working
Milestone

Comments

@deathaxe
Copy link

With regards to sublimelsp/LSP-lemminx#9

It appears LemMinX tries to register workspace/executeCommand twice.

One instance for xml.validation.current.file and one for xml.validation.all.files command.

With a birds eye onto https://microsoft.github.io/language-server-protocol/specifications/specification-3-15 I'd expect one registration message for workspace/executeCommand with commands containing a list of all available commands.

Console log:

LSP: lemminx: registering capability: codeActionProvider
LSP: lemminx: registering capability: completionProvider
LSP: lemminx: registering capability: documentHighlightProvider
LSP: lemminx: registering capability: hoverProvider
LSP: lemminx: registering capability: renameProvider
LSP: lemminx: registering capability: definitionProvider
LSP: lemminx: registering capability: typeDefinitionProvider
LSP: lemminx: registering capability: referencesProvider
LSP: lemminx: registering capability: documentFormattingProvider
LSP: lemminx: registering capability: rangeFormattingProvider
LSP: lemminx: registering capability: documentSymbolProvider
LSP: lemminx: registering capability: executeCommandProvider
LSP: lemminx: registering capability: executeCommandProvider
LSP: executeCommandProvider is already registered at executeCommandProvider.id with ID 8dce5c84-5665-4060-84d6-c58ebedc49d7, overwriting

Communication log:

:: <-- lemminx client/registerCapability(12): {'registrations': [{'registerOptions': {'id': '8dce5c84-5665-4060-84d6-c58ebedc49d7', 'commands': ['xml.validation.current.file']}, 'id': '8dce5c84-5665-4060-84d6-c58ebedc49d7', 'method': 'workspace/executeCommand'}]}
:: >>> lemminx 12: None
:: <-- lemminx client/registerCapability(13): {'registrations': [{'registerOptions': {'id': '2dbb8863-94a3-45eb-99b9-a78343e3f591', 'commands': ['xml.validation.all.files']}, 'id': '2dbb8863-94a3-45eb-99b9-a78343e3f591', 'method': 'workspace/executeCommand'}]}
:: >>> lemminx 13: None
@angelozerr
Copy link
Contributor

@deathaxe I try to fix your issue (very quckly with #938) could you tell meif it work for you. Thanks!

@BoykoAlex could you review my PR please? I needto manage the unregister commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants