Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support xml.format.enforceQuoteStyle setting with experimental formatter #1249

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Support xml.format.enforceQuoteStyle setting with experimental formatter #1249

merged 1 commit into from
Jul 14, 2022

Conversation

JessicaJHee
Copy link
Contributor

Fixes #1239

Signed-off-by: Jessica He [email protected]

@JessicaJHee JessicaJHee force-pushed the issue1239 branch 2 times, most recently from 46a61a1 to 293e60e Compare July 8, 2022 20:37
@datho7561 datho7561 self-requested a review July 11, 2022 13:28
@datho7561
Copy link
Contributor

I think that there is also a isQuote in StringUtils, separate from isQuoted, which just handles the situation you are talking about

@JessicaJHee
Copy link
Contributor Author

I think that there is also a isQuote in StringUtils, separate from isQuoted, which just handles the situation you are talking about

Ohh I completely missed that, thank you!

@angelozerr
Copy link
Contributor

Once my comments will be fixed, the code looks good.

@datho7561 could you please test the pr too.

datho7561
datho7561 approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works very well for me. Well done, Jessica! Once you've addressed Angelo's comments, I'll merge it.

@JessicaJHee JessicaJHee marked this pull request as ready for review July 14, 2022 13:57
@angelozerr
Copy link
Contributor

Once this pr will be meŕged @JessicaJHee could yiu create a pr in vscode xml in Format.md and package.json to remove comment which says that your settings is now supported.

@datho7561 datho7561 merged commit 0b0b63b into eclipse:master Jul 14, 2022
@JessicaJHee JessicaJHee deleted the issue1239 branch July 14, 2022 18:01
@JessicaJHee JessicaJHee mentioned this pull request Jul 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon left review comments

@angelozerr angelozerr angelozerr left review comments

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support xml.format.enforceQuoteStyle setting with experimental formatter
4 participants
@JessicaJHee @datho7561 @angelozerr @fbricon