Check for null elementOptionality entry for code action cvc_complex_type_2_4_b #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
reviewed
Aug 18, 2022
| @@ -335,7 +335,8 @@ public boolean isOptional(String childElementName) { | |||
| } | |||
| } | |||
| } | |||
| return elementOptionality.get(childElementName); | |||
| Boolean isOptional = elementOptionality.get(childElementName); | |||
There was a problem hiding this comment.
I think it should be better to write (not tested):
return elementOptionality.getOrDefault(childElementName, false);
|
@JessicaJHee do you think we could have a simple test for this PR? If it is too complex, please ignore my comment. |
yes we can, but the result from the code action would be incorrect. |
|
Yes you are righr but this test will be fixed again with I mean that you will have test that you should adjust. |
|
Thanks @JessicaJHee ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1280
Signed-off-by: Jessica He [email protected]