Support spaceBeforeEmptyCloseTag setting with experimental formatter #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This setting was already supported prior to this PR, I have updated the test. |
|
Could you add 2 tests:
: test with some line separator, and it should replace them just with one space. |
JessicaJHee
force-pushed
the
issue1245-spaceBeforeEmptyCloseTag
branch
from
826e01a
to
8a8865e
Compare
angelozerr
reviewed
Aug 24, 2022
...clipse/lemminx/services/format/experimental/XMLFormatterSetSpaceBeforeEmptyCloseTagTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jessica He <[email protected]>
JessicaJHee
force-pushed
the
issue1245-spaceBeforeEmptyCloseTag
branch
from
8a8865e
to
970ebad
Compare
|
Thanks @JessicaJHee ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1245
Signed-off-by: Jessica He [email protected]