Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set experimental formatter to default #1381

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Set experimental formatter to default #1381

merged 1 commit into from
Dec 2, 2022

Conversation

JessicaJHee
Copy link
Contributor

  • removes xml.format.experimental setting
  • introduces new xml.format.legacy to revert to old formatter
  • renames and moves tests

Fixes #1377

Signed-off-by: Jessica He [email protected]

@JessicaJHee JessicaJHee force-pushed the switch-to-experimental-formatter branch from ce2875a to 2c7f337 Compare November 28, 2022 19:21
@datho7561 datho7561 self-requested a review November 28, 2022 22:01
datho7561
datho7561 requested changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few things, but looking pretty good!

...eclipse.lemminx/src/test/java/org/eclipse/lemminx/extensions/xsi/XSIFormatterLegacyTest.java Show resolved Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/services/XMLFormatter.java Outdated Show resolved Hide resolved
@JessicaJHee JessicaJHee force-pushed the switch-to-experimental-formatter branch from 2c7f337 to e256df1 Compare November 30, 2022 16:30
@JessicaJHee JessicaJHee mentioned this pull request Nov 30, 2022
Merged
@datho7561 datho7561 mentioned this pull request Dec 1, 2022
Merged
@JessicaJHee JessicaJHee force-pushed the switch-to-experimental-formatter branch from e256df1 to bf5c18a Compare December 2, 2022 18:59
@JessicaJHee JessicaJHee force-pushed the switch-to-experimental-formatter branch from bf5c18a to 910c677 Compare December 2, 2022 19:27
datho7561
datho7561 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks Jessica, and thanks for all your work on the formatter!

@datho7561 datho7561 merged commit e5bfd0a into eclipse:main Dec 2, 2022
@JessicaJHee JessicaJHee modified the milestone: 0.23.0 Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch experimental formatter to default
2 participants
@JessicaJHee @datho7561