Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Surround with ..." when using the binary server #1410

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

datho7561
Copy link
Contributor

Signed-off-by: David Thompson [email protected]

@datho7561 datho7561 added this to the 0.23.1 milestone Dec 15, 2022
@datho7561 datho7561 added the bug Something isn't working label Dec 15, 2022
@datho7561
Copy link
Contributor Author

Before anyone merges, I'm going to update the CHANGELOG in this PR as well

@datho7561 datho7561 changed the title Fix surround with tag in binary Fix surround with tag when using the binary server Dec 15, 2022
@rgrunber
Copy link
Contributor

rgrunber commented Dec 15, 2022

I can confirm that when

[Trace - 12:16:56 p.m.] Sending request 'workspace/executeCommand - (28)'.
Params: {
    "command": "xml.refactor.surround.with",
...
...

is sent, the response is

[Trace - 12:16:56 p.m.] Received response 'workspace/executeCommand - (28)' in 2ms.
Result: {}

with the binary server which results in the command failing. This fixes the issue. I think we just need to keep in mind for the future that any new class that we use in the response requires an update to the reflection config.

@datho7561 datho7561 changed the title Fix surround with tag when using the binary server Fix "Surround with ..." when using the binary server Dec 15, 2022
@datho7561 datho7561 merged commit 06cf067 into eclipse:main Dec 15, 2022
@datho7561 datho7561 deleted the binary-surround-with-tag branch December 15, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants