Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments throws off diagnostic (cvc-complex-type.2.3) mark onto the wrong location #1496

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Comments throws off diagnostic (cvc-complex-type.2.3) mark onto the wrong location #1496

merged 1 commit into from
Mar 1, 2023

Conversation

angelozerr
Copy link
Contributor

Comments throws off diagnostic (cvc-complex-type.2.3) mark onto the wrong location

Fixes #1495

@angelozerr
Copy link
Contributor Author

This PR should fix #1495:

The test content from the pom.xml is now reported as error instead of the comment:

image

@datho7561 datho7561 self-requested a review March 1, 2023 16:32
datho7561
datho7561 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, Angelo!

@datho7561 datho7561 merged commit fe8beb4 into eclipse:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

@JessicaJHee JessicaJHee Awaiting requested review from JessicaJHee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments throws off diagnostic (cvc-complex-type.2.3) mark onto the wrong location
2 participants
@angelozerr @datho7561