Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML language server should report select range capability in non dynamic mean #1507

Merged
merged 1 commit into from
Mar 20, 2023
Merged

XML language server should report select range capability in non dynamic mean #1507

merged 1 commit into from
Mar 20, 2023

Conversation

angelozerr
Copy link
Contributor

XML language server should report select range capability in non dynamic mean

@angelozerr angelozerr mentioned this pull request Mar 20, 2023
Merged
datho7561
datho7561 approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@datho7561 datho7561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Selection range is still working properly after this change. I tested this PR with the binary version, and that didn't cause any issues.

@datho7561 datho7561 added the bug Something isn't working label Mar 20, 2023
@datho7561 datho7561 added this to the 0.25.0 milestone Mar 20, 2023
@datho7561 datho7561 merged commit 9bb4dd2 into eclipse:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datho7561 datho7561 datho7561 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@angelozerr @datho7561